Conversation
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
|
I assume I need to install something on mac for this? I get this error: ❯ bun run dev
$ bun run index.ts --dev
Building Vortex RFC site...
Processing accepted/0005-extension-types.md...
error: Cannot find module 'shiki/wasm' from '/Users/connor/.bun/install/cache/shiki@4.0.0@@@1/dist/bundle-full.mjs'Shouldn't bun be able to add this on its own? Edit: I had to do https://shiki.style/guide/install with |
connortsui20
left a comment
connortsui20
left a comment
There was a problem hiding this comment.
If its possible to get bun to auto-install shiki then I think this is good to go
| ``` | ||
|
|
||
| RFC filenames follow the format `NNNN-slug.md` (e.g., `0001-galp-patches.md`). | ||
| Numbering is global across all states - no duplicates allowed. |
There was a problem hiding this comment.
I believe we are doing this by PR number
|
Unfortunately I'm not sure how to get bun npm or any other js package manager to auto install. It's pretty common you need to run |
|
I like having multiple states, but it's not ideal to have proposed RFCs on develop since it requires a new PR to update / approve them. Maybe the move is to have the build-time thing use the GitHub CLI to pull open PRs? |
3 participants
Adds proposal states, which are just directories that indicate what state a proposal is in. When a proposal gets accepted, it moves to the
acceptedfolder. When it's been implemented, it moves to thecompletedfolder.Also updates our build to use Shiki, which is a fully build-time syntax highlighter, doesn't require the client to fetch any deps so page loads still stay small and fast. I have configured it to only use the grammars for Rust, markdown, and Python for now. CI times are still < 10 seconds.